Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to break these kind of changes down into single changes; for now a lot of proof of concept ideas. Here is a new tox recipe used via
tox -e isort
that keeps our imports PEP compliant and consistent. This buys us:This uses
isort
a very popular import linter and for now is entirely opt in viatox -e isort
which at present only covers thetest/
directory; I'd like to expand it acrossselenium/
also once we are happy with it as a POC. I want to bolt on some other stuff as well which will be somewhat similar.If you like it i will follow up PRs with additional tooling to help us improve our contributing UX and general code consistency. Eventually we will look at enforcing the new recipes (including the existing flake8 stuff) through a
tox -e linting
'parent', but for now let's be opt in to avoid any teething issues.Thanks
This is a sub part of #10761
edit: This was open for a while, I went ahead and applied it over
selenium/
&tests/