Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPromise() thenable fix #11048

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Conversation

cstringer
Copy link
Contributor

Addressing issue #11045

This reverts changes to the isPromise() utility function (84dd610) which causes the function to return false for "thenable" objects (i.e. objects or functions exposing a then() method, such as WebElementPromise)

Additionally assertions have been added to the promise_test.js test case for isPromise() to verify the above behavior.

Motivation and Context

Without the above change, "thenable" objects/functions will not pass the isPromise() test, and subsequest methods which rely on it (such as WebDriver.wait() fail.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally. Was able to reproduce the issue!

Thank you for the fix @cstringer !

@cstringer
Copy link
Contributor Author

I'm very happy to contribute, thank you @harsha509 !

@cstringer cstringer deleted the is-promise-thenable-fix branch September 30, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants