Add support for FedCM commands #12087
Conversation
|
|
|
Would you mind creating an issue for us to track this? We'll need to implement it in all the bindings, not just Java. Thanks. |
Oh I wasn't expecting anyone to look at this yet, I have it marked as draft. But thanks, I filed #12088 I am not sure if you are saying that the pull request needs to do it in all bindings? |
|
I watch all the things, lol. |
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.openqa.selenium.chromium; |
There was a problem hiding this comment.
Since this is based on "Federated Credential Management API", the package name shouldn't be chromium, but probably something parallel to the virtualauthenticator. Perhaps org.openqa.selenium.federatedcredentialmanagement?
| * Used by classes to indicate that they can interact with FedCM dialogs. | ||
| */ | ||
| @Beta | ||
| public interface HasFedCm { |
There was a problem hiding this comment.
Please consider a more verbose name so someone not familiar with the spec can understand what this is.
As specified in: https://fedidcg.github.io/FedCM/#automation Currently implemented in Chromium.
|
closing this and reopening a new PR in hopes of fixing the CLA check |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This adds the FedCM webdriver commands that are specified in:
https://fedidcg.github.io/FedCM/#automation
Currently implemented in Chromium, but Firefox is interested as well:
w3c-fedid/FedCM#395 (comment)
w3c-fedid/FedCM#465 (comment)
Motivation and Context
This lets identity providers and relying parties use Selenium's Java API to control
the FedCM browser dialog to test that their website works correctly when
using the FedCM API.
Types of changes
Checklist