[py] mapped all error codes in errorhandler.py
to corresponding exception object.
#12190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Mapped all error codes in
ErrorCode
object inremote/errorhandler.py
to corresponding exception object by creating a new objectExceptionMapping
.Motivation and Context
In
ErrorHandler
object inremote/errorhandler.py
, there is a giant conditional statement which actually assigns an exception object to a variableexception_class
depending onstatus
.All error codes and its corresponding values are maintained in
ErrorCode
object. Through multiple conditional statements, an exception object is being assigned to variableexception_class
depending onstatus
in response.I have mapped all error codes in
ErrorCode
object and its corresponding exception object in a separateExceptionClass
object, so that multipleif-elif-else
block is avoided inErrorHandler
object.Added a new logic to assign
exception_class
variable by replacing conditional statements. Now the code inErrorHandler
object is reduced to a great extent.Types of changes
Checklist