-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Use CfT endpoints to discover chromedriver 115+ #12208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bonigarcia!
If I understand correctly, we try first the new endpoint, and if no ChromDriver is found there, we go back to LATEST_RELEASE
, right?
And then, eventually, when Chrome 115 is released, the information for ChromeDriver will be present in the Chrome for Testing endpoints. I hope I got that one right.
Yes, something like that. Let me explain a bit. First, we try to discover the browser (Chrome) version (by running some command(s) in the shell). Using the found version, there are different cases for discovering the driver (chromedriver) version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
If anyone is looking for a temporary fix until the next release, you can specify an older version in ChromeDriverManager: |
|
@occamssafetyrazor you are mixing up the Selenium Manager which is in the Selenium code and the WebDriver Manager project, which is not. It is confusing because @bonigarcia writes both. :) |
I still see the issue with 115 chrome version. |
@Akkasim46 That is due to a problem in chromedriver 115 in macOS (see GoogleChromeLabs/chrome-for-testing#30). As a workaround in Selenium (and macOS), you can specify the Chrome binary path as follows (or its equivalent in other binding language):
|
Thanks a lot @bonigarcia |
The workaround will not be needed when the chromedriver team ships a new version of chromedriver 115 with the fix. Selenium or WebDriverManager does not cause it. |
Description
The Chrome team is doing recently relevant changes related to Chrome for Testing (CfT). In particular, the metadata for discovering chromedriver as of version 115 is now different. This PR makes the required changes in the Rust-side of Selenium Manager to support chromedriver 115+ downloads using the new CfT endpoints.
Motivation and Context
This change is required to be shipped with the bindings at least when Chrome 115 is released as stable (according to the Chrome roadmap, by July 12, 2023).
Types of changes
Checklist