Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Replace the :capabilities paramater with :options in API examples #12626

Conversation

tatsuyafw
Copy link
Contributor

Description

The :capabilities parameter for webdriver classes is deprecated but still used in API example docs.

This change replaces the :capabilites parameter with :options.

Motivation and Context

I would like to keep the API documentation up to date.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2023

CLA assistant check
All committers have signed the CLA.

@tatsuyafw tatsuyafw marked this pull request as ready for review August 29, 2023 11:09
The :capabilities parameter for webdriver classes is deprecated
but still used in API example docs.

This change replaces the :capabilities parameter with :options.
@tatsuyafw tatsuyafw force-pushed the rb-replace-capabilites-paramater-with-options-in-api-docs branch from 382c8be to 70b17ed Compare August 29, 2023 11:11
@tatsuyafw tatsuyafw changed the title [rb] Replace the :capabilites paramater with :options in API examples [rb] Replace the :capabilities paramater with :options in API examples Aug 29, 2023
@tatsuyafw
Copy link
Contributor Author

I've fixed the typo in my commit message.

@titusfortner titusfortner merged commit 9e7615d into SeleniumHQ:trunk Aug 29, 2023
@titusfortner
Copy link
Member

Thank you for fixing this!

@tatsuyafw tatsuyafw deleted the rb-replace-capabilites-paramater-with-options-in-api-docs branch August 30, 2023 01:13
CandorContent pushed a commit to CandorContent/selenium that referenced this pull request Aug 30, 2023
SeleniumHQ#12626)

The :capabilities parameter for webdriver classes is deprecated
but still used in API example docs.

This change replaces the :capabilities parameter with :options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants