Better way to handle SM env variable and unsupported platform #12761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronment variable This allows people to build or download the binary as necessary and place it in any directory It may also be helpful for package managers or people who have permissions issues in directories
…vironment variable
titusfortner
force-pushed
the
se_mgr_path
branch
3 times, most recently
from
ac55971 to
68c5eb2
Compare
|
Thanks for this. For right now I decided to go with minimal change to existing code that ensures platform is not evaluated if ENV is set. I'm not making any changes as to whether we should or shouldn't throw when platform is not recognized, though I think we probably should come to some agreement on that for all languages in a future release. I'm not entirely sure how UNIX platforms should be handled for instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just a better way how to handle env var for sm path. And react appropriately if it is not specified.
Motivation and Context
Make Selenium better, improve #12752
Types of changes
Checklist