-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Remove System.Drawing.Common as package dependency #12781
[dotnet] Remove System.Drawing.Common as package dependency #12781
Conversation
I think where this is coming from is that Java supports:
If .NET doesn't allow saving as png in default libraries... We can't just remove this. We can deprecate the method. Another option that might be nice is to move the ability to save a stream as a PNG to the support package. |
Now all users will get a warning. And those, who are really converting image to different formats, will get exception at runtime. |
Please rebase on trunk and fix conflicts so I can better see what this is doing. :) |
I think we want to do this in stages. If we are removing functionality we should mark it as obsolete for a couple releases, then remove it. |
Agree, I will prepare separate PR just to mark methods as obsolete. Keeping this one as open until we decide completely remove it. |
I think we are ready to land it. |
Two weeks for a breaking change in a minor release is somewhat annoying. The Obsolete message was merged 22nd October and the breaking change was introduced Nov 10. (#12878) |
The obsolete message shipped with v4.14 (25 Sep) and breaking change shipped with v4.16 (06 Dec). Selenium project doesn't follow semantic versioning, sorry for inconvenience. |
This is continuation of #12777, please review that first.
Description
I think selenium is not responsible to convert images from one format to another. It is already enough for users to deal with images in
png
format, even it is possible to save image as file.If user wants to convert image, then he is able to get image as bytes and use any other 3rd-party library especially designed to work with graphics.
Motivation and Context
Continue my way to reduce package dependencies.
Types of changes
Checklist