-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Add page load strategy enum #13258
[py] Add page load strategy enum #13258
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13258 +/- ##
==========================================
+ Coverage 57.95% 57.99% +0.03%
==========================================
Files 88 88
Lines 5333 5338 +5
Branches 224 224
==========================================
+ Hits 3091 3096 +5
Misses 2018 2018
Partials 224 224 ☔ View full report in Codecov by Sentry. |
70bbc90
to
46b32e9
Compare
46b32e9
to
3836951
Compare
One concern I have is that enum string objects remain Enums until a json library parses it as a string object. But if tests pass, this is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isaulv do you have specific code recommendation for that? |
@titusfortner the enum object is fine so long it gets ran through a JSON converter. If it doesn't, and that caps object is used in some other context it may not work right. |
Description
Add
PageLoadStrategy
to get rid of writing the webdriver's page load strategy manually.Motivation and Context
Fixes issue#13236:
Types of changes
Checklist