-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js] Fix linting #13753
[js] Fix linting #13753
Conversation
PR Description updated to latest commit (fd61808)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fix linting for JS binding
Motivation and Context
Types of changes
Checklist
Type
enhancement, bug_fix
Description
setFiles_command_test.js
.storage_test.js
anddriver_factory.js
.driver_factory.js
to improve clarity and correctness.BUILD.bazel
for efficiency.Changes walkthrough
script_test.js
Simplify Preload Script Handling in Bidi Tests
javascript/node/selenium-webdriver/test/bidi/script_test.js
getWindowHandle
calls in multiple test cases.setFiles_command_test.js
Standardize File System Module Import
javascript/node/selenium-webdriver/test/bidi/setFiles_command_test.js
fs
module import to use the more commonrequire('fs')
insteadof
require('node:fs')
.storage_test.js
Clean Up Storage Test Imports
javascript/node/selenium-webdriver/test/bidi/storage_test.js
ignore
import.driver_factory.js
Refactor Driver Factory for Clarity and Correctness
javascript/node/selenium-webdriver/test/driver_factory.js
Builder
import.require
comment for ESLint.Browser.SAFARI
reference to use importedBrowser
enum.BUILD.bazel
Optimize Linting and Formatting Test Configurations
javascript/node/selenium-webdriver/BUILD.bazel
size = "small"
toeslint-test
andprettier-test
configurations.