Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet][rb][java][js][py] Automated Browser Version Update #13928

Merged
merged 2 commits into from
May 13, 2024

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented May 11, 2024

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

Copy link
Contributor

PR Description updated to latest commit (b92b02a)

Copy link
Contributor

PR Review 🔍

⏱️ Estimated effort to review [1-5]

2, because the changes are straightforward and limited to updating URLs and checksums for browser versions. The scope and impact of the changes are clear, making it easier to review.

🧪 Relevant tests

No

⚡ Possible issues

Possible Dependency Issue: Ensure that the new browser versions are compatible with existing tests and do not introduce regressions or incompatibilities.

🔒 Security concerns

No

Copy link
Contributor

PR Code Suggestions ✨

CategorySuggestions                                                                                                                                                       
Maintainability
Use a variable for the browser version to simplify future updates.

Consider using a variable for the version number of Microsoft Edge to ensure consistency
and ease of updates in the future. This will help in maintaining and updating the version
number across different package types without having to manually replace it in multiple
places.

common/repositories.bzl [126-146]

-url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/f12b802a-7a08-47df-b40e-04570cf4e133/MicrosoftEdge-124.0.2478.97.pkg"
-url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_124.0.2478.97-1_amd64.deb"
+edge_version = "124.0.2478.97"
+url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/f12b802a-7a08-47df-b40e-04570cf4e133/MicrosoftEdge-" + edge_version + ".pkg"
+url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_" + edge_version + "-1_amd64.deb"
 
Bug prevention
Update the move dictionary to use the version variable for accurate path references.

Ensure that the move dictionary key paths are updated to reflect the new version number.
This helps in avoiding errors related to file paths that do not exist.

common/repositories.bzl [129]

 move = {
-  "MicrosoftEdge-124.0.2478.97.pkg/Payload/Microsoft Edge.app": "Edge.app",
+  "MicrosoftEdge-" + edge_version + ".pkg/Payload/Microsoft Edge.app": "Edge.app",
 }
 

Copy link
Contributor

codiumai-pr-agent-pro bot commented May 11, 2024

CI Failure Feedback 🧐

(Checks updated until commit ddc9d29)

Action: JavaScript / Browser Tests (chrome) / Browser Tests (chrome)

Failed stage: Run Bazel [❌]

Failed test name: //javascript/node/selenium-webdriver:chrome-browser-tests

Failure summary:

The action failed due to multiple failures in the
//javascript/node/selenium-webdriver:chrome-browser-tests. The primary issue was an Error: Cannot
find module '../../net' which indicates a missing or incorrectly referenced module required by the
test files. This error occurred consistently across multiple attempts to run the test, as indicated
by the logs from different test attempts.

Relevant error logs:
1:  ##[group]Operating System
2:  Ubuntu
...

974:  Package 'php-symfony-debug-bundle' is not installed, so not removed
975:  Package 'php-symfony-dependency-injection' is not installed, so not removed
976:  Package 'php-symfony-deprecation-contracts' is not installed, so not removed
977:  Package 'php-symfony-discord-notifier' is not installed, so not removed
978:  Package 'php-symfony-doctrine-bridge' is not installed, so not removed
979:  Package 'php-symfony-doctrine-messenger' is not installed, so not removed
980:  Package 'php-symfony-dom-crawler' is not installed, so not removed
981:  Package 'php-symfony-dotenv' is not installed, so not removed
982:  Package 'php-symfony-error-handler' is not installed, so not removed
...

1949:  Setting up fonts-terminus-otb (4.48-3.1) ...
1950:  Processing triggers for install-info (6.8-4build1) ...
1951:  Processing triggers for mailcap (3.70+nmu1ubuntu1) ...
1952:  Processing triggers for fontconfig (2.13.1-4.2ubuntu5) ...
1953:  Processing triggers for hicolor-icon-theme (0.17-2) ...
1954:  Processing triggers for libc-bin (2.35-0ubuntu3.7) ...
1955:  Processing triggers for man-db (2.10.2-1) ...
1956:  Processing triggers for menu (2.1.47ubuntu4) ...
1957:  /usr/share/menu/procps: 1: Syntax error: word unexpected (expecting ")")
1958:  /usr/share/menu/psmisc: 1: Syntax error: word unexpected (expecting ")")
1959:  /usr/share/menu/monodoc-http: 1: Syntax error: word unexpected (expecting ")")
1960:  /usr/share/menu/bc: 1: Syntax error: word unexpected (expecting ")")
1961:  /usr/share/menu/microsoft-edge.menu: 1: Syntax error: word unexpected (expecting ")")
1962:  /usr/share/menu/dash: 1: Syntax error: word unexpected (expecting ")")
1963:  /usr/share/menu/bash: 1: Syntax error: word unexpected (expecting ")")
1964:  /usr/share/menu/telnet: 1: Syntax error: word unexpected (expecting ")")
1965:  /usr/share/menu/tcl8.6: 1: Syntax error: word unexpected (expecting ")")
1966:  /usr/share/menu/google-chrome.menu: 1: Syntax error: word unexpected (expecting ")")
1967:  /usr/share/menu/tk8.6: 1: Syntax error: word unexpected (expecting ")")
1968:  NEEDRESTART-VER: 3.5
1969:  NEEDRESTART-KCUR: 6.5.0-1018-azure
1970:  NEEDRESTART-KEXP: 6.5.0-1018-azure
1971:  NEEDRESTART-KSTA: 1
1972:  Warning: Failed to open file(/usr/share/fluxbox/nls/C.UTF-8/fluxbox.cat)
1973:  for translation, using default messages.
1974:  Failed to read: session.ignoreBorder
1975:  Setting default value
1976:  Failed to read: session.forcePseudoTransparency
1977:  Setting default value
1978:  Failed to read: session.colorsPerChannel
1979:  Setting default value
1980:  Failed to read: session.doubleClickInterval
1981:  Setting default value
1982:  Failed to read: session.tabPadding
1983:  Setting default value
1984:  Failed to read: session.styleOverlay
1985:  Setting default value
1986:  Failed to read: session.slitlistFile
1987:  Setting default value
1988:  Failed to read: session.appsFile
1989:  Setting default value
1990:  Failed to read: session.tabsAttachArea
1991:  Setting default value
1992:  Failed to read: session.cacheLife
1993:  Setting default value
1994:  Failed to read: session.cacheMax
1995:  Setting default value
1996:  Failed to read: session.autoRaiseDelay
1997:  Setting default value
1998:  Failed to read: session.ignoreBorder
1999:  Setting default value
2000:  Failed to read: session.forcePseudoTransparency
2001:  Setting default value
2002:  Failed to read: session.colorsPerChannel
2003:  Setting default value
2004:  Failed to read: session.doubleClickInterval
2005:  Setting default value
2006:  Failed to read: session.tabPadding
2007:  Setting default value
2008:  Failed to read: session.styleOverlay
2009:  Setting default value
2010:  Failed to read: session.slitlistFile
2011:  Setting default value
2012:  Failed to read: session.appsFile
2013:  Setting default value
2014:  Failed to read: session.tabsAttachArea
2015:  Setting default value
2016:  Failed to read: session.cacheLife
2017:  Setting default value
2018:  Failed to read: session.cacheMax
2019:  Setting default value
2020:  Failed to read: session.autoRaiseDelay
2021:  Setting default value
2022:  Failed to read: session.screen0.opaqueMove
2023:  Setting default value
2024:  Failed to read: session.screen0.fullMaximization
2025:  Setting default value
2026:  Failed to read: session.screen0.maxIgnoreIncrement
2027:  Setting default value
2028:  Failed to read: session.screen0.maxDisableMove
2029:  Setting default value
2030:  Failed to read: session.screen0.maxDisableResize
2031:  Setting default value
2032:  Failed to read: session.screen0.workspacewarping
2033:  Setting default value
2034:  Failed to read: session.screen0.showwindowposition
2035:  Setting default value
2036:  Failed to read: session.screen0.autoRaise
2037:  Setting default value
2038:  Failed to read: session.screen0.clickRaises
2039:  Setting default value
2040:  Failed to read: session.screen0.defaultDeco
2041:  Setting default value
2042:  Failed to read: session.screen0.tab.placement
2043:  Setting default value
2044:  Failed to read: session.screen0.windowMenu
2045:  Setting default value
2046:  Failed to read: session.screen0.noFocusWhileTypingDelay
2047:  Setting default value
2048:  Failed to read: session.screen0.workspaces
2049:  Setting default value
2050:  Failed to read: session.screen0.edgeSnapThreshold
2051:  Setting default value
2052:  Failed to read: session.screen0.window.focus.alpha
2053:  Setting default value
2054:  Failed to read: session.screen0.window.unfocus.alpha
2055:  Setting default value
2056:  Failed to read: session.screen0.menu.alpha
2057:  Setting default value
2058:  Failed to read: session.screen0.menuDelay
2059:  Setting default value
2060:  Failed to read: session.screen0.tab.width
2061:  Setting default value
2062:  Failed to read: session.screen0.tooltipDelay
2063:  Setting default value
2064:  Failed to read: session.screen0.allowRemoteActions
2065:  Setting default value
2066:  Failed to read: session.screen0.clientMenu.usePixmap
2067:  Setting default value
2068:  Failed to read: session.screen0.tabs.usePixmap
2069:  Setting default value
2070:  Failed to read: session.screen0.tabs.maxOver
2071:  Setting default value
2072:  Failed to read: session.screen0.tabs.intitlebar
2073:  Setting default value
2074:  Failed to read: session.screen0.focusModel
2075:  Setting default value
2076:  Failed to read: session.screen0.tabFocusModel
2077:  Setting default value
2078:  Failed to read: session.screen0.focusNewWindows
2079:  Setting default value
2080:  Failed to read: session.screen0.focusSameHead
2081:  Setting default value
2082:  Failed to read: session.screen0.rowPlacementDirection
2083:  Setting default value
2084:  Failed to read: session.screen0.colPlacementDirection
2085:  Setting default value
2086:  Failed to read: session.screen0.windowPlacement
2087:  Setting default value
2088:  Failed to read: session.ignoreBorder
2089:  Setting default value
2090:  Failed to read: session.forcePseudoTransparency
2091:  Setting default value
2092:  Failed to read: session.colorsPerChannel
2093:  Setting default value
2094:  Failed to read: session.doubleClickInterval
2095:  Setting default value
2096:  Failed to read: session.tabPadding
2097:  Setting default value
2098:  Failed to read: session.styleOverlay
2099:  Setting default value
2100:  Failed to read: session.slitlistFile
2101:  Setting default value
2102:  Failed to read: session.appsFile
2103:  Setting default value
2104:  Failed to read: session.tabsAttachArea
2105:  Setting default value
2106:  Failed to read: session.cacheLife
2107:  Setting default value
2108:  Failed to read: session.cacheMax
2109:  Setting default value
2110:  Failed to read: session.autoRaiseDelay
2111:  Setting default value
2112:  Failed to read: session.screen0.opaqueMove
2113:  Setting default value
2114:  Failed to read: session.screen0.fullMaximization
2115:  Setting default value
2116:  Failed to read: session.screen0.maxIgnoreIncrement
2117:  Setting default value
2118:  Failed to read: session.screen0.maxDisableMove
2119:  Setting default value
2120:  Failed to read: session.screen0.maxDisableResize
2121:  Setting default value
2122:  Failed to read: session.screen0.workspacewarping
2123:  Setting default value
2124:  Failed to read: session.screen0.showwindowposition
2125:  Setting default value
2126:  Failed to read: session.screen0.autoRaise
2127:  Setting default value
2128:  Failed to read: session.screen0.clickRaises
2129:  Setting default value
2130:  Failed to read: session.screen0.defaultDeco
2131:  Setting default value
2132:  Failed to read: session.screen0.tab.placement
2133:  Setting default value
2134:  Failed to read: session.screen0.windowMenu
2135:  Setting default value
2136:  Failed to read: session.screen0.noFocusWhileTypingDelay
2137:  Setting default value
2138:  Failed to read: session.screen0.workspaces
2139:  Setting default value
2140:  Failed to read: session.screen0.edgeSnapThreshold
2141:  Setting default value
2142:  Failed to read: session.screen0.window.focus.alpha
2143:  Setting default value
2144:  Failed to read: session.screen0.window.unfocus.alpha
2145:  Setting default value
2146:  Failed to read: session.screen0.menu.alpha
2147:  Setting default value
2148:  Failed to read: session.screen0.menuDelay
2149:  Setting default value
2150:  Failed to read: session.screen0.tab.width
2151:  Setting default value
2152:  Failed to read: session.screen0.tooltipDelay
2153:  Setting default value
2154:  Failed to read: session.screen0.allowRemoteActions
2155:  Setting default value
2156:  Failed to read: session.screen0.clientMenu.usePixmap
2157:  Setting default value
2158:  Failed to read: session.screen0.tabs.usePixmap
2159:  Setting default value
2160:  Failed to read: session.screen0.tabs.maxOver
2161:  Setting default value
2162:  Failed to read: session.screen0.tabs.intitlebar
2163:  Setting default value
2164:  Failed to read: session.screen0.focusModel
2165:  Setting default value
2166:  Failed to read: session.screen0.tabFocusModel
2167:  Setting default value
2168:  Failed to read: session.screen0.focusNewWindows
2169:  Setting default value
2170:  Failed to read: session.screen0.focusSameHead
2171:  Setting default value
2172:  Failed to read: session.screen0.rowPlacementDirection
2173:  Setting default value
2174:  Failed to read: session.screen0.colPlacementDirection
2175:  Setting default value
2176:  Failed to read: session.screen0.windowPlacement
2177:  Setting default value
2178:  Failed to read: session.screen0.slit.acceptKdeDockapps
2179:  Setting default value
2180:  Failed to read: session.screen0.slit.autoHide
2181:  Setting default value
2182:  Failed to read: session.screen0.slit.maxOver
2183:  Setting default value
2184:  Failed to read: session.screen0.slit.placement
2185:  Setting default value
2186:  Failed to read: session.screen0.slit.alpha
2187:  Setting default value
2188:  Failed to read: session.screen0.slit.onhead
2189:  Setting default value
2190:  Failed to read: session.screen0.slit.layer
2191:  Setting default value
2192:  Failed to read: session.screen0.toolbar.autoHide
2193:  Setting default value
2194:  Failed to read: session.screen0.toolbar.maxOver
2195:  Setting default value
2196:  Failed to read: session.screen0.toolbar.visible
2197:  Setting default value
2198:  Failed to read: session.screen0.toolbar.alpha
2199:  Setting default value
2200:  Failed to read: session.screen0.toolbar.layer
2201:  Setting default value
2202:  Failed to read: session.screen0.toolbar.onhead
2203:  Setting default value
2204:  Failed to read: session.screen0.toolbar.placement
2205:  Setting default value
2206:  Failed to read: session.screen0.toolbar.height
2207:  Setting default value
2208:  Failed to read: session.screen0.iconbar.mode
2209:  Setting default value
2210:  Failed to read: session.screen0.iconbar.alignment
2211:  Setting default value
2212:  Failed to read: session.screen0.iconbar.iconWidth
2213:  Setting default value
2214:  Failed to read: session.screen0.iconbar.iconTextPadding
2215:  Setting default value
2216:  Failed to read: session.screen0.iconbar.usePixmap
...

2309:  �[32m[1,756 / 2,702]�[0m Extracting npm package chokidar@3.5.3; 0s disk-cache ... (3 actions, 0 running)
2310:  �[35mWARNING: �[0m/home/runner/work/selenium/selenium/BUILD.bazel:13:22: input 'package' to //:.aspect_rules_js/node_modules/fsevents@2.3.2/lc is a directory; dependency checking of directories is unsound
2311:  �[32m[2,417 / 2,702]�[0m Checking 1 JS files in @@io_bazel_rules_closure//closure/library/dom:textassert; 0s disk-cache ... (3 actions, 0 running)
2312:  �[32m[2,702 / 2,703]�[0m Testing //javascript/node/selenium-webdriver:chrome-browser-tests; 0s local, disk-cache
2313:  �[31m�[1mFAIL: �[0m//javascript/node/selenium-webdriver:chrome-browser-tests (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test_attempts/attempt_1.log)
2314:  �[31m�[1mFAIL: �[0m//javascript/node/selenium-webdriver:chrome-browser-tests (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test_attempts/attempt_2.log)
2315:  �[32m[2,702 / 2,703]�[0m Testing //javascript/node/selenium-webdriver:chrome-browser-tests; 1s local, disk-cache
2316:  �[31m�[1mFAIL: �[0m//javascript/node/selenium-webdriver:chrome-browser-tests (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test.log)
2317:  �[31m�[1mFAILED: �[0m//javascript/node/selenium-webdriver:chrome-browser-tests (Summary)
2318:  /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test.log
2319:  /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test_attempts/attempt_1.log
2320:  /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test_attempts/attempt_2.log
2321:  �[32mINFO: �[0mFrom Testing //javascript/node/selenium-webdriver:chrome-browser-tests:
2322:  ==================== Test output for //javascript/node/selenium-webdriver:chrome-browser-tests:
2323:  Exception during run: Error: Cannot find module '../../net'
...

2354:  requireStack: [
2355:  '/home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/bin/javascript/node/selenium-webdriver/lib/test/httpserver.js',
2356:  '/home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/bin/javascript/node/selenium-webdriver/lib/test/fileserver.js',
2357:  '/home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/bin/javascript/node/selenium-webdriver/test/actions_test.js'
2358:  ]
2359:  }
2360:  ================================================================================
2361:  ==================== Test output for //javascript/node/selenium-webdriver:chrome-browser-tests:
2362:  Exception during run: Error: Cannot find module '../../net'
...

2393:  requireStack: [
2394:  '/home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/bin/javascript/node/selenium-webdriver/lib/test/httpserver.js',
2395:  '/home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/bin/javascript/node/selenium-webdriver/lib/test/fileserver.js',
2396:  '/home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/bin/javascript/node/selenium-webdriver/test/actions_test.js'
2397:  ]
2398:  }
2399:  ================================================================================
2400:  ==================== Test output for //javascript/node/selenium-webdriver:chrome-browser-tests:
2401:  Exception during run: Error: Cannot find module '../../net'
...

2436:  ]
2437:  }
2438:  ================================================================================
2439:  �[32mINFO: �[0mFound 1 test target...
2440:  Target //javascript/node/selenium-webdriver:chrome-browser-tests up-to-date:
2441:  bazel-bin/javascript/node/selenium-webdriver/chrome-browser-tests.sh
2442:  �[32mINFO: �[0mElapsed time: 23.998s, Critical Path: 2.06s
2443:  �[32mINFO: �[0m2687 processes: 1649 disk cache hit, 1030 internal, 4 linux-sandbox, 4 local.
2444:  �[32mINFO: �[0mBuild completed, 1 test FAILED, 2687 total actions
2445:  //javascript/node/selenium-webdriver:chrome-browser-tests                �[0m�[31m�[1mFAILED�[0m in 3 out of 3 in 0.4s
2446:  Stats over 3 runs: max = 0.4s, min = 0.3s, avg = 0.3s, dev = 0.0s
2447:  /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test.log
2448:  /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test_attempts/attempt_1.log
2449:  /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/chrome-browser-tests/test_attempts/attempt_2.log
2450:  Executed 1 out of 1 test: �[0m�[31m�[1m1 fails locally�[0m.
2451:  �[0m
2452:  ##[error]Process completed with exit code 3.

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

@diemol diemol merged commit df54f95 into trunk May 13, 2024
39 of 40 checks passed
@diemol diemol deleted the pinned-browser-updates branch May 13, 2024 10:02
sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Oct 29, 2024
…HQ#13928)

Update pinned browser versions

Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants