You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2, because the changes are minimal and localized to configuration files, but understanding the implications of these changes requires specific knowledge about npm and GitHub package registries.
🧪 Relevant tests
No
⚡ Possible issues
Possible Security Risk: The use of NODE_AUTH_TOKEN in a publicly visible file (.github/workflows/nightly.yml) could potentially expose sensitive information if not properly secured.
Use npm config set with the --global flag instead of appending directly to ~/.npmrc to avoid potential issues with file permissions or user-specific configurations
To avoid potential issues with file permissions or user-specific configurations, consider using the --global flag with npm config set instead of appending directly to ~/.npmrc.
-echo "//npm.pkg.github.com/:_authToken=${NODE_AUTH_TOKEN}" >> ~/.npmrc-echo "@seleniumhq:registry=https://npm.pkg.github.com" >> ~/.npmrc-echo "always-auth=true" >> ~/.npmrc+npm config set //npm.pkg.github.com/:_authToken=${NODE_AUTH_TOKEN} --global+npm config set @seleniumhq:registry https://npm.pkg.github.com --global+npm config set always-auth true --global
Suggestion importance[1-10]: 8
Why: This suggestion improves the script by using npm config set with the --global flag, which is a more robust and system-wide approach compared to directly appending to ~/.npmrc. This avoids potential issues with file permissions and ensures consistency across environments.
8
Maintainability
Remove duplicate lines that append the same configurations to both ~/.npmrc and .npmrc to ensure consistency and avoid redundancy
To ensure consistency and avoid redundancy, remove the duplicate lines that append the same configurations to both ~/.npmrc and .npmrc.
Why: The suggestion to remove duplicate lines is valid and improves maintainability by avoiding redundancy. However, it's less critical than the first suggestion as it does not address potential system-wide issues but rather focuses on cleaning up the script.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
configuration changes, enhancement
Description
.npmrc
and~/.npmrc
to ensure proper access to GitHub packages.@seleniumhq
packages in.npmrc
and~/.npmrc
to use GitHub's npm registry.always-auth
is set to true in.npmrc
and~/.npmrc
to enforce authentication for all npm operations.Changes walkthrough 📝
nightly.yml
Update npm registry and authentication settings for nightly builds
.github/workflows/nightly.yml
.npmrc
and~/.npmrc
.@seleniumhq
packages in.npmrc
and~/.npmrc
.always-auth
is set to true in.npmrc
and~/.npmrc
.