[build] create a stage release workflow for after the pre-release PR #14122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qodo-merge-pro
bot
added
enhancement
configuration changes
Review effort [1-5]: 4
labels
PR Reviewer Guide 🔍(Review updated until commit 465c31b)
|
PR Code Suggestions ✨
|
diemol
approved these changes
Jun 12, 2024
|
I verified it was able to execute and create the draft release, but the default release notes generation is generated from the previous release, which is nightly. So I want to explore deleting and redeploying nightly around this workflow. More importantly, I'm getting failures trying to build some of these assets remotely. Might just be a ruby thing, need to investigate. Will need to try this on the next release 😞 |
titusfortner
force-pushed
the
stage_release
branch
from
45db5d2 to
e24844c
Compare
CI Failure Feedback 🧐(Checks updated until commit ffb4ab6)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
…rged This builds assets, creates draft GitHub Release, and creates documentation update PR
titusfortner
force-pushed
the
stage_release
branch
from
ffb4ab6 to
41bae4b
Compare
qodo-merge-pro
bot
added
Review effort [1-5]: 3
and removed
Review effort [1-5]: 4
labels
|
Persistent review updated to latest commit 465c31b |
PR Code Suggestions ✨
|
|
Well, this isn't everything I wanted it to be (description updated above), and I sure hope that --config=release works the way I hope it will. Merging. |
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Oct 29, 2024
…eleniumHQ#14122) This builds assets on RBE and creates draft GitHub Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
User description
./go all:release[--config=release]everything has already been built and you're pretty much just downloading the top-level generated assets for publishingI can't get it to complete on my fork because it won't do the RBE portion on my fork, and it is too late for me to spend more time on this tonight.Hmm, it would make more sense to have aall:packagetask in the Rakefile so we don't have to call each of these individually. I'll update that.We can theoretically have this "stage release" be a "full release", but this continues to require manual intervention for anything that can't be taken back. 😁
We definitely want to add document generation and nightly version updates to this next, so we don't have to deal with that locally. Nightly update probably doesn't need manual intervention, but the API docs changes can be one big PR that gets reviewed before merging.... Anyway, that's next steps..Update
I did implement documentation updating. I put it in a different workflow in case there's an issue with the staging release workflow so we can do it separately (again, wasn't able to really compare this from my fork)This dramatically changes the:docstasks in Rakefile, it isn't doing the complete flow with manual queries and pushes and checking out origin. It is just switching to gh-pages and making the commit. So if you're doing it manually you need to pay attention to it more.Update 2
PR Type
Enhancement, Configuration changes
Description
stage-release.yml) for release staging, which triggers on closed pull requests and handles building and packaging for multiple languages (Java, .NET, Ruby, Python, Node).Rakefileby removing the creation of release notes and focusing on building and packaging.create_release_notestask from theRakefile.Changes walkthrough 📝
stage-release.yml
Add GitHub Actions workflow for release staging.github/workflows/stage-release.yml
and Node projects.
Rakefile
Simplify release task and remove release notes generationRakefile
create_release_notestask.PR Type
Enhancement, Configuration changes
Description
stage-release.yml) to automate the release staging process. This workflow triggers on PR merge, tags the release, builds assets, creates a draft GitHub Release, and updates the nightly tag.Rakefileto include a new taskall:packagefor packaging artifacts. Modified theall:releasetask to use this new packaging task. Removed thecreate_release_notestask from theRakefile.Changes walkthrough 📝
stage-release.yml
Add GitHub Actions workflow for release staging.github/workflows/stage-release.yml
Rakefile
Update Rakefile with new packaging task and remove release notes taskRakefile
all:packageto package artifacts.all:releasetask to include the newall:packagetask.create_release_notestask.