-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox_profile.py: use with
statement in zipfile as Python 2.x support is dropped
#14489
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
with
statement in zipfile as Python 2.x supportwith
statement in zipfile as Python 2.x support is dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Use
with
statement inzipFile
asTODO
says and support forPython 2.x
is now droppedMotivation and Context
Solves the TODO Comment
Types of changes
Checklist
PR Type
enhancement
Description
firefox_profile.py
to use thewith
statement for handlingzipfile.ZipFile
, improving code readability and resource management.Changes walkthrough 📝
firefox_profile.py
Use `with` statement for zipfile handling in Firefox profile
py/selenium/webdriver/firefox/firefox_profile.py
with
statement forzipfile.ZipFile
.