-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] Fix tests for Grid status endpoint and UI #14605
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit 625bb94)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Fix test CI - RBE
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
NodeStatus
forsessionTimeout
andheartbeatPeriod
usingcompareTo
.GridStatusHandler
to map node status with detailed attributes includingheartbeatPeriod
andsessionTimeout
in milliseconds.LocalDistributorTest
to includeheartbeatPeriod
in node setup and assertions.OverallGridTest
to ensure proper navigation in test cases.Changes walkthrough 📝
NodeStatus.java
Fix NodeStatus comparison logic for time durations
java/src/org/openqa/selenium/grid/data/NodeStatus.java
sessionTimeout
andheartbeatPeriod
usingcompareTo
.OverallGridTest.java
Fix UI path in OverallGridTest for session and node checks
java/test/org/openqa/selenium/grid/gridui/OverallGridTest.java
GridStatusHandler.java
Enhance GridStatusHandler with detailed node attributes
java/src/org/openqa/selenium/grid/router/GridStatusHandler.java
heartbeatPeriod
andsessionTimeout
in milliseconds.LocalDistributorTest.java
Update LocalDistributorTest to include heartbeat period
java/test/org/openqa/selenium/grid/distributor/local/LocalDistributorTest.java
heartbeatPeriod
to node setup and test assertions.