[dotnet] Propagate IWebDriver.GetAttribute
obsoletion to WebDriver
#14802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
The
IWebDriver.GetAttribute
method was recently depreciated. This change propagates the obsoletion to the concrete implementations.Motivation and Context
Anyone using
WebDriver
directly (which has been my default experience, especially thanks to thevar
keyword) will not see the warnings.Types of changes
Checklist
PR Type
enhancement
Description
GetAttribute
method as obsolete in bothEventFiringWebDriver
andWebElement
classes.GetDomAttribute
orGetDomProperty
as alternatives.GetAttribute
will be removed in Selenium 6.Changes walkthrough 📝
EventFiringWebDriver.cs
Mark `GetAttribute` method as obsolete in EventFiringWebDriver
dotnet/src/support/Events/EventFiringWebDriver.cs
GetAttribute
method as obsolete.WebElement.cs
Mark `GetAttribute` method as obsolete in WebElement
dotnet/src/webdriver/WebElement.cs
GetAttribute
method as obsolete.