Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Add future-proofing note on Base64UrlEncoder #14821

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

RenderMichael
Copy link
Contributor

@RenderMichael RenderMichael commented Nov 27, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Addresses request in #14813

Motivation and Context

This note will help us remember about the Base64Url type that is available on .NET 9+

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

documentation


Description


Changes walkthrough 📝

Relevant files
Documentation
Base64UrlEncoder.cs
Add future-proofing note and enable nullable reference types

dotnet/src/webdriver/Internal/Base64UrlEncoder.cs

  • Enabled nullable reference types.
  • Added a comment about future usage of Base64Url type in .NET 9+.
  • +5/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @RenderMichael
    Copy link
    Contributor Author

    Should this type be internal?

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko
    Copy link
    Member

    We kept origin, goal, context. Thank you Michael.

    @nvborisenko nvborisenko merged commit 6dc99f5 into SeleniumHQ:trunk Nov 27, 2024
    1 check passed
    @RenderMichael RenderMichael deleted the dotnet-base64-url branch November 27, 2024 22:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants