Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Bump rules_jvm_external to 6.6 and use the maven resolver #14829

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Nov 29, 2024

User description

By using the maven resolver, we can make use of BOMs, which mean less duplication of version numbers within the install tag.


PR Type

enhancement, dependencies


Description

  • Updated rules_jvm_external to version 6.6 in the Bazel configuration to leverage the latest features and improvements.
  • Simplified the Maven dependency management by using BOMs (Bill of Materials), reducing the need for specifying individual version numbers.
  • Introduced the use of the Maven resolver to handle dependencies more efficiently.
  • Updated the java/maven_install.json file to reflect new artifact hashes and versions, ensuring compatibility with the updated dependencies.

Changes walkthrough 📝

Relevant files
Enhancement
MODULE.bazel
Update Bazel dependencies and use Maven resolver                 

MODULE.bazel

  • Updated rules_jvm_external version from 6.3 to 6.6.
  • Simplified Maven dependencies by removing specific version numbers.
  • Added BOMs for dependency management.
  • Introduced Maven resolver for dependency resolution.
  • +31/-25 
    Dependencies
    maven_install.json
    Update Maven install JSON with new hashes and versions     

    java/maven_install.json

  • Updated artifact hashes and versions.
  • Removed conflict resolution entries.
  • Adjusted package and dependency listings.
  • +34/-46 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Compatibility
    Removing version numbers from dependencies and using BOMs could lead to version conflicts if the BOMs are not properly maintained or have conflicting version requirements

    Build Stability
    Switching to maven resolver may impact build reproducibility and stability. Verify that builds remain consistent across different environments

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    By using the maven resolver, we can make use of BOMs, which mean
    less duplication of version numbers within the `install` tag.
    @shs96c shs96c merged commit ff7fa52 into SeleniumHQ:trunk Nov 29, 2024
    9 checks passed
    @shs96c shs96c deleted the bump-rules-java branch November 29, 2024 15:29
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant