-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Moved Rust binary settings to pyproject.toml
from setup.py
#14837
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@VietND96 Can you please build this one for me from CI and upload to test PyPI. So that i will verify the binaries.. |
I think other script need to be updated, since publish CI failed https://github.com/SeleniumHQ/selenium/actions/runs/12113072764/job/33767482214 |
Dist package is https://test.pypi.org/project/selenium/4.28.0.202412041759/ |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved Rust binary settings to
pyproject.toml
fromsetup.py
thus completely eliminating the need ofsetup.py
Motivation and Context
setup.py
as all the settings are moved topyproject.toml
bazel build //py:selenium-wheel
which is successful.selenium
from.whl
file, the installation was successful.selenium-manager
is present inselenium.webdriver.common
folder (in /linux, /macos, /windows)--no-binary
option as well.Types of changes
Checklist
PR Type
enhancement
Description
setup.py
file, migrating its configurations topyproject.toml
.pyproject.toml
to include Rust binary settings forselenium-manager
.setup.py
from the source files.Changes walkthrough 📝
setup.py
Remove setup.py and migrate configurations
py/setup.py
setup.py
file entirely.setup.py
by moving configurations.pyproject.toml
Add Rust binary settings to pyproject.toml
py/pyproject.toml
selenium-manager
.BUILD.bazel
Update Bazel build configuration for setup.py removal
py/BUILD.bazel
setup.py
from the list of source files.