Replace faulty load balancer with queue Fixes #1673 #1674
Conversation
| @@ -58,77 +53,4 @@ public void removeIfPresent() { | |||
| registry.stop(); | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testProxySortingByIdle() throws Exception { | |||
There was a problem hiding this comment.
removing tests and not adding one is not beneficial here. Please add a test, otherwise I'm not sure the premise of your bug #1673 is correct.
Also, since this test existed and was passing, not sure what was wrong with this chunk of code.
There was a problem hiding this comment.
hmmm, well there was a test which in fact didn't test what it was supposed to because it didn't work (much respect to my friend dima). so in fact the test was worse than having no test as it made you think it worked but it didn't, as you can see from the issue!
|
honestly i would be happy to optimize the code and maybe even add a test if it didn't take nearly an hour just to build the software; apparently whatever tool there is does not do incremental builds, or i can't figure out how to use it. making a simple change on this project is byzantine... |
|
It appears that this code is working correctly and this change shouldn't be warranted, going to close this until further proof is shown there is something at fault here (see comments on #1673 ) |
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement