[js] Fix timeouts' url #2185
Merged
[js] Fix timeouts' url #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST URLs now comply with http://w3c.github.io/webdriver/webdriver-spec.html\#set-timeout
|
Does this break compatibility with the Selenium server and ChromeDriver? |
|
Sorry, I haven't manually checked (I was expecting automated tests to check the APIs behavior). I'll get back to you with testing results. Edit on June 6th: I'll bring testing results by tomorrow. Edit on June 7th: I tested Chrome, and Chrome behind Selenium server. They both pass. See content of the tests here https://github.com/JohanLorenzo/geckodriver-bugs/tree/cant-set-timeout . I'll work on adding these tests in the PR. |
|
@jleyba Tests done manually and new ones added. r? Travis failed due to an error with buck. I don't think it's related to my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Results
GeckoDriver (wires) is more strict about the URLs that you provide to it. They should comply with http://w3c.github.io/webdriver/webdriver-spec.html\#set-timeout . In this case we should not have
/timeouts/async_script, but only/timeouts.r? @jleyba
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement