Fix issue #8232. Changed the ExecuteJavaScript extension method to corre...

[chrisblock]

...ctly detect if the script result is convertible to the generic type.

[jimevans]

Two things. First, you need to indicate whether or not you've signed the CLA.

Second, using the is operator implies a hidden cast to the specified type, which is a perf hit and should be flagged by static analysis (FxCop). Two other possible approaches might be using the as operator with a null check, which may be problematic with generics; or adding type constraints to the type parameter.

[chrisblock]

I have signed the CLA. Sorry about that. Is there some other way you need me to indicate it than by merely saying so here?

Secondly, as to the is operator, I would rather change it to typeof (T).IsInstanceOfType(result) == false (which is what I had it as before ReSharper suggested otherwise) than the as cast and check for null, which, as you suspect, would cause issues when T is a value type.

Should I just commit that change, or should I revert, re-change and commit and then re-issue the pull request (to keep the selenium commit log clean)?

[chrisblock]

I will re-issue the pull request after having made the modifications.