Fixed the usage information in documentation of "save_screenshot".

[igauravsehrawat]

"save_screenshot" method was assigned from "get_screenshot_as_file"
as result of that it's usage information was
"driver.get_screenshot_as_file('/Screenshots/foo.png')" which is wrong.
So I defined a separate method which is calling
"get_screenshot_as_file" but with it's correct usage information as
"driver.save_screenshot('/Screenshots/foo.png')"

Fixes #3651

• By placing an X in the preceding checkbox, I verify that I have signed the Contributor License Agreement

[igauravsehrawat]

As per code contributor's guidelines. I ran the tests using .go clean test but it didn't pass due some Could not start a new session. message, it seems like system configuration problem. If anyone can guide me what I am missing that would great.

Verbose error message: https://gist.github.com/igauravsehrawat/fc66e8c8822b6c2fa61f31127372f525

Thanks

[isaulv]

@igauravsehrawat Why is aliasing get_screenshot_as_file wrong? It may not be the cleanest code, but I don't see a reason to duplicate code.

[igauravsehrawat]

@Dude-x Thanks for replying.

@cgoldberg Suggested here #3651 (comment). It was producing wrong documentation because of aliasing.

Thanks

[isaulv]

@igauravsehrawat Since proper documentation is more helpful than duplicate code, I'll see if I can get a core committer to make this change. Did you sign the CLA?

[igauravsehrawat]

@Dude-x Yes, I did sign the CLA.

Thanks a lot.

[lmtierney]

@igauravsehrawat can you throw a check in the checkbox for the CLA in your PR comment

[lmtierney]

This needs to be just

return self.get_screenshot_as_file(filename)

[igauravsehrawat]

My bad, confused myself with explicit self logic.
Fixed it.

[lmtierney]

thanks @igauravsehrawat

[igauravsehrawat]

Thank you all for the help.