Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo unexpectedAlertBehavior ->unexpectedAlertBehaviour #3813

Merged
merged 2 commits into from
Apr 22, 2017

Conversation

Heky
Copy link
Contributor

@Heky Heky commented Apr 11, 2017

can't set unexpectedAlertBehaviour in selenium server.
viz search https://github.com/SeleniumHQ/selenium/search?utf8=%E2%9C%93&q=unexpectedAlertBehaviour&type=

typo unexpectedAlertBehavior ->unexpectedAlertBehaviour
can't set unexpectedAlertBehaviour in selenium server.
viz search https://github.com/SeleniumHQ/selenium/search?utf8=%E2%9C%93&q=unexpectedAlertBehaviour&type=
@@ -132,7 +132,7 @@ const Capability = {
* Defines how the driver should handle unexpected alerts. The value should
* be one of "accept", "dismiss", or "ignore".
*/
UNEXPECTED_ALERT_BEHAVIOR: 'unexpectedAlertBehavior',
UNEXPECTED_ALERT_BEHAVIOUR: 'unexpectedAlertBehaviour',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can change the string value, but not the code constant

@Heky
Copy link
Contributor Author

Heky commented Apr 20, 2017

I changed that to minimalistic change :)

@jleyba jleyba merged commit fbb099c into SeleniumHQ:master Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants