Always use JSON.parse for bot.json.parse #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goog.json.parse is deprecated and about to be removed in late September 2017. This change prepares for that.
|
I wonder if anybody is setting NATIVE_JSON=false anymore when compiling. I wouldn't think so... IE7 was probably the last one that needed it. |
|
Oh, hm. Regardless, I would think that's unnecessary at this point. |
Tom-Trumper
pushed a commit
to Tom-Trumper/selenium
that referenced
this pull request
Sep 11, 2017
goog.json.parse is deprecated and about to be removed in late September 2017. This change prepares for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goog.json.parse is deprecated and about to be removed in late September 2017. This change prepares for that.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement