Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chromeOptions key for capabilities #4622

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

kereliuk
Copy link
Contributor

@kereliuk kereliuk commented Sep 1, 2017

@lmtierney
Copy link
Member

@JKereliuk do you know how far back this works with older chromedriver versions, for backward compatibility? Will we break anything if we send both, or will it use goog and ignore the latter if both are sent?

@kereliuk
Copy link
Contributor Author

kereliuk commented Sep 1, 2017

Good point, this works only as of Chromedriver 2.31.
Not sure if that is far enough back to justify.
@shs96c I noticed you updated this for the Java bindings, what do you think about the python bindings?

@shs96c
Copy link
Member

shs96c commented Sep 14, 2017

giphy

The W3C payload should only have the goog: prefixed version, but the JSON Wire Protocol payload can have both, and that's legit.

@p0deje
Copy link
Member

p0deje commented Sep 18, 2017

Or you can just use goog:chromeOptions like .NET does.

@shs96c
Copy link
Member

shs96c commented Sep 18, 2017

You need both if you're going to support older versions of chrome.

@p0deje
Copy link
Member

p0deje commented Sep 18, 2017

Yep, while .NET doesn't do this since 3.5.2.

¯_(ツ)_/¯

@jimevans
Copy link
Member

That's because I was a little overzealous in making sure the latest was supported going forward. Well, that, and being on "not the latest version of Chrome" takes a fair bit of work on the user's part.

@lmtierney lmtierney merged commit 3578c0f into SeleniumHQ:master Oct 3, 2017
@lmtierney
Copy link
Member

Thanks @JKereliuk!

shs96c pushed a commit that referenced this pull request May 18, 2018
Make selenium webdriver compatible to latest selenium (> 3.8) and chrome versions.

See #4622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants