Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ResourceTiming parser in CDP Network #7415

Merged
merged 2 commits into from
Aug 5, 2019
Merged

added ResourceTiming parser in CDP Network #7415

merged 2 commits into from
Aug 5, 2019

Conversation

adiohana
Copy link
Contributor

@adiohana adiohana commented Jul 21, 2019 •
edited
Loading

@adiohana adiohana mentioned this pull request Jul 21, 2019
Closed
@p0deje p0deje added the C-java label Jul 22, 2019
@takeyaqa
Copy link
Contributor

selenium/java/client/src/org/openqa/selenium/devtools/network/model/Response.java

Lines 454 to 456 in a64a19f

case "fromServiceWorker":
fromDiskCache = input.nextBoolean();
break;

How about this line? Is it fromServiceWorker ?

shs96c
shs96c requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just a couple of points, and we're good to go! Thank you for this PR!

java/client/src/org/openqa/selenium/devtools/network/model/ResourceTiming.java Outdated Show resolved Hide resolved
java/client/src/org/openqa/selenium/devtools/network/model/ResourceTiming.java Outdated Show resolved Hide resolved
@adiohana
Copy link
Contributor Author

adiohana commented Aug 2, 2019

@shs96c
changes are done. can we merge this?

@shs96c
Copy link
Member

shs96c commented Aug 5, 2019

A quick skim suggests this is great :) Thank you! Merging now!

@shs96c shs96c merged commit cab7ff4 into SeleniumHQ:master Aug 5, 2019
@takeyaqa takeyaqa mentioned this pull request Aug 5, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c requested changes

Assignees
No one assigned
Labels
C-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adiohana @takeyaqa @shs96c @p0deje