Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add null check before returning isDisplayed value #9299

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Mar 18, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add null check before returning isDisplayed value.
Fixes #9266 from Java client end.

Motivation and Context

Related to the issue mentioned above when isDisplayed() throws an NullPointerException randomly when running with the Firefox driver. To get the result of isDisplayed() function the script https://github.com/SeleniumHQ/selenium/blob/trunk/rb/lib/selenium/webdriver/atoms/isDisplayed.js is run on the driver end. Sometimes the Firefox driver returns null and a null check would safeguard against that. It could be similar to #4555.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pujagani!

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@diemol diemol merged commit f1cb54f into SeleniumHQ:trunk Mar 18, 2021
@PiotrZgadzaj
Copy link

I don't know what is selenium release calendar, but do you plan to include that in some selenium 3.x release? If so then when ?

@diemol
Copy link
Member

diemol commented Mar 18, 2021

We do not backport fixes to previous releases, so this will be available in beta-3, which should be released (I guess) by mid or end of April.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isDisplayed throws NullPointerException
3 participants