[dotnet] Use vendor-specific method names for additional Chromium options. #9906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames
ChromiumOptions.AddAdditionalChromeOption
to the more vendor-neutralChromiumOptions.AddAdditionalChromiumOption
. Make this method protected and add vendor-specific versions of this method to the derived classesChromeOptions
andEdgeOptions
.Motivation and Context
This avoids potential confusion with customers using
EdgeOptions
having to use the Chrome-brandedAddAdditionalChromeOption
for capabilities that may in fact be Edge-specific (e.g. webview2 or device portal options). The existingAddAdditionalChromeOption
is preserved onChromeOptions
to avoid breaking ChromeOptions users that call this method.Types of changes
Checklist