Changed icons page for FontAwesome 5 port #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2018
|
@hammy2899 it looks like quite a few icons are placed in multiple categories, for example I'm going to try my best to dedupe them. I'm also adding icon search to make it easier to use. |
|
@jlukic Ye I was debating whether to add duplicate icons because FA5 docs has them in multiple categories but do whatever you feel is best. |
|
I'm going to go ahead and leave the duplicates in docs, I think it makes sense to remove them from the overrides file as they will appear as duplicate css rules in the compiled css. |
|
Ye I totally agree 👍 |
|
I've merged this in from https://github.com/Semantic-Org/Semantic-UI-Docs/tree/hammy2899-fa5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the icons page to complete the FontAwesome 5 port.
I have commented out some code in the
docs.cssfile to fix the new code iconsHere is the PR for the FontAwesome port Semantic-Org/Semantic-UI#6085