Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings do not take effect #231

Closed
Bouke opened this issue May 16, 2018 · 2 comments
Closed

Settings do not take effect #231

Bouke opened this issue May 16, 2018 · 2 comments

Comments

@Bouke
Copy link
Contributor

Bouke commented May 16, 2018

const options = (app && app.project.config(app.env)['SemanticUI'])

I've patched this locally include (app && app.options['SemanticUI']), otherwise the settings as advertised aren't picked up.

    const options = (app && app.options['SemanticUI']) || {};

Example config:

# ember-cli-build.js
'use strict';

const EmberApp = require('ember-cli/lib/broccoli/ember-app');

module.exports = function(defaults) {
  let app = new EmberApp(defaults, {
    SemanticUI: {
      import: {
        css: true,
        javascript: false,
        images: false,
        fonts: false
      }
    }
  });
  return app.toTree();
};
@omairvaiyani
Copy link

+1 Just tried a fresh install and javascript: false is still loading Javascript; we have jQuery disabled so this is a blocking issue

@championswimmer
Copy link
Collaborator

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants