Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with resolving configuration #232

Merged
merged 2 commits into from
May 25, 2018

Conversation

Bouke
Copy link
Contributor

@Bouke Bouke commented May 16, 2018

See #231 for additional information. Beware that I've removed the following config resolvers:

(app && app.project.config(app.env)['SemanticUI'])
|| (app && app.project.config(app.env)['semantic-ui-ember'])

I don't know what these do and where they get their config from. The change proposed in this PR reflects the actual documentation and has been tested on ember-cli 3.0.

@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          14       14           
  Lines         516      516           
  Branches       24       24           
=======================================
  Hits          422      422           
  Misses         94       94
Impacted Files Coverage Δ
index.js 75.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2287f49...e50fe9b. Read the comment docs.

we have (due to legacy reasons) used `SemanticUI`, but people generally set addon config via an object with same name as the addon package name. so support both
@championswimmer championswimmer merged commit 4cb8b5b into Semantic-Org:master May 25, 2018
@Bouke Bouke deleted the Bouke-patch-1 branch June 5, 2018 09:00
@Bouke Bouke restored the Bouke-patch-1 branch June 5, 2018 09:00
@Bouke
Copy link
Contributor Author

Bouke commented Jun 5, 2018

When do you expect to create a new release? Now that the configuration issue has been resolved, it would be great to start using an official release.

@Bouke Bouke deleted the Bouke-patch-1 branch July 12, 2019 05:46
@Bouke Bouke restored the Bouke-patch-1 branch July 12, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants