fix(Search): strict validation to avoid errors when not using title (#…

…2654)

* strict validation to avoid errors when using title

* updated tests

src/modules/Search/Search.js

@@ -71,7 +71,7 @@ export default class Search extends Component {
      */
     results: PropTypes.oneOfType([
       PropTypes.arrayOf(PropTypes.shape(SearchResult.propTypes)),
-      PropTypes.object,
+      PropTypes.shape(SearchCategory.propTypes),
     ]),
 
     /** Whether the search should automatically select the first result after searching. */

src/modules/Search/SearchResult.d.ts

@@ -45,7 +45,7 @@ export interface SearchResultProps {
   renderer?: (props: SearchResultProps) => Array<React.ReactElement<any>>;
 
   /** Display title. */
-  title?: string;
+  title: string;
 }
 
 declare const SearchResult: React.ComponentClass<SearchResultProps>;

src/modules/Search/SearchResult.js

@@ -73,7 +73,7 @@ export default class SearchResult extends Component {
     renderer: PropTypes.func,
 
     /** Display title. */
-    title: PropTypes.string,
+    title: PropTypes.string.isRequired,
   }
 
   static defaultProps = {

test/specs/modules/Search/SearchResult-test.js

@@ -1,7 +1,9 @@
 import SearchResult from 'src/modules/Search/SearchResult'
 import * as common from 'test/specs/commonTests'
 
+const requiredProps = { title: '' }
+
 describe('SearchResult', () => {
-  common.isConformant(SearchResult)
+  common.isConformant(SearchResult, { requiredProps })
   common.propKeyOnlyToClassName(SearchResult, 'active')
 })