-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(Popup): replace event-stack (#4499)
* refactor(event-stack): replace event-stack with window.addEventListener in Popup * refactor(popup): Move hideOnScroll feature to Portal component to get rid of hacky timout that causes remounting Portal component. * perf(portal): wrap closePortal in useEventCallback to prevent scroll event resubscribed every render * fix(portal): Replace AbortController with removeEventListener to support older browsers --------- Co-authored-by: Dominik Dosoudil <dosoudil@insoft.cz>
- Loading branch information
1 parent
d70adfc
commit 80a60c9
Showing
3 changed files
with
41 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters