-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SUIR to be compatible with SUI 2.3 #2550
Comments
Oh, great idea. I think we just ship this as a new breaking change. We can then bundle all 2.3.x changes into one release. Thanks for starting the list! |
Updated the list with a few more and also added a link to the full CHANGELOG. There may be one or two I missed. And with how we render popups via a Portal, I am not sure we have to worry about the update allowing you to trigger a popup from other blocks of markup. |
I think we're ready to go here. Changing labels. |
@davidhenley any issues tagged with |
Any chance your Modal documentation can be updated to reflect the modal placement issue? |
In any case, it seems wise to add a warning on the docs homepage that Semantic UI React is not officially compatible with Semantic UI 2.3 yet, and that using the 2.3 css in combination with the latest react version is at your own risk until this issue is resolved. |
See #2657, I've made updates for |
@layershifter I have some time blocked out tomorrow afternoon to tackle If I have the time I may also be able to tackle |
@brianespinosa I've merged PR for |
There is a message for Modals in 2.3.1: https://github.com/Semantic-Org/Semantic-UI/blob/master/RELEASE-NOTES.md.
|
In light of the release notes for 2.3.1 referenced above, it seems like support for either version of the modals is the long term strategy for SUI core styles. I need to dig in over there to find out for sure, but if this is the case, we'll probably have to go with my earliest proposal in this comment.
If indeed there will be the ability to go either way on this in the styles, I'll make sure the PR has the above option for our modals as well. |
I haven't received a reply yet on my question here for @jlukic so I think for now I am just going to proceed without some sort of legacy/fallback prop. I'll try to keep a close eye on whatever happens with modals in the next version of SUI since it sounds like there are going to be some additional breaking changes incoming. Starting a branch on this now in the office as I've blocked out some official work hours to get this working. PR should be up this afternoon. |
To update on Modal positioning, see this comment from the linked issue in SUI:
|
Quick fix for modal positioning, working here with SUI 2.3.1 & SUIR 0.79.1:
|
@franckboudraa, and for anyone landing here, I would recommend against what you have proposed for A safer solution for anyone wanting to use the newest version of SUI styles and this incompatible version of SUIR would be safer doing the following:
There are other problems you'll encounter using the latest styles, but those above changes should at least fix modals. The last fix for this is coming in PR #2689. |
This may be part of what @brianespinosa was referring to regarding Icons, but since the shift to FontAwesome 5, an error is being thrown for "invalid" icon names. They are raising an error (it looks like) because SUI.js does not have the correct list of icon names for FA5. Thankfully, the icons still show correctly on the page. |
@reddishtg those are only proptype errors. If you are not using another component broken by these changes and want to continue using a newer version of the CSS than we currently support until #2657 gets merged and deployed, you can just declare your icon names in the |
What versions of semantic-ui-react and semantic-ui-css are sufficiently compatible with each other? It is very difficult for a newbie, like myself, to use this library when it is unclear which versions of libraries should be used together. Placing this information, if available, in the README would be a huge help. |
|
@arnm Please take a look at the VERY first thing at the top of the README.md |
Creating this as a container for referencing other issues that are likely to pop up with the release of SUI 2.3 which happened today. Feel free to edit this and add related issues below for tracking.
Notes about what is new in this release:
https://semantic-ui.com/introduction/new.html
Full CHANGELOG:
https://github.com/Semantic-Org/Semantic-UI/blob/master/RELEASE-NOTES.md
Known issues so far. Please edit this list to add or link to issues:
Icon
component to use new FontAwesome 5.0 icons.zoom
andglow
fullTextSearch: 'exact'
vsfuzzy
The text was updated successfully, but these errors were encountered: