breaking(Modal): update shorthand functionality

[levithomason]

Breaking Changes

Previously, shorthand Modal actions required passing button props objects with triggerClose: true on buttons that should close the Modal.

Now, all shorthand Modal actions buttons close the Modal automatically. The triggerClose property has been removed.

Before

<Modal
  header='Reminder!'
  content='Call Benjamin.'
  actions={[
    { key: 'snooze', content: 'Snooze', triggerClose: true },
    { key: 'done', content: 'Done', positive: true, triggerClose: true },
  ]}
/>

After

<Modal
  header='Reminder!'
  content='Call Benjamin.'
  actions={[
    'Snooze',
    { key: 'done', content: 'Done', positive: true },
  ]}
/>

---

Blocking #1542

This PR:

• removes the triggerClose shorthand Modal actions property
• makes all shorthand actions close the Modal
• fix prop types / typings

[layershifter]

I'm not sure about this change. I think that we should use there customPropTypes.collectionShorthand.

[layershifter]

customPropTypes.itemShorthand disallows usage of this prop with children. If we will make this change, we should also make changes in the render method.

[codecov-io]

Codecov Report

Merging #1599 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1599   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         148     148           
  Lines        2590    2590           
======================================
  Hits         2585    2585           
  Misses          5       5

Impacted Files	Coverage Δ
src/modules/Modal/ModalActions.js	100% <ø> (ø)	⬆️
src/modules/Modal/Modal.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c4972...169c2cf. Read the comment docs.

[layershifter]

I've pushed some changes there:

• updated to latest master;
• reverted change of type in typings;
• changed actions to collection shorthand;
• added onActionClick prop;
• fixed broken tests.

TODO

• make a decision about closeIcon prop, it will be breaking change if we'll left it as customPropTypes.itemShorthand;
• solve warnings with implementsCreateMethod test on ModalActions, I think we to update it with new option, that will skip non array inputs.

@levithomason I'll be glad to hear your thoughts.

[a-x-]

ping

[levithomason]

I've rebased to the latest master and resolved all issues:

closeIcon - Leaving this as is for minimal churn, allowing with children.

Updated actions propType to itemShorthand since it is not an array of buttons but the props to Modal.Actions. You can pass an array of buttons because mapValueToProps for ModalActions maps the array to the Modal.Actions actions prop, which is an array of buttons.

[levithomason]

Released in semantic-ui-react@0.72.0