feat(Dropdown): lazyLoad prop for menu items #1918
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1918 +/- ##
==========================================
+ Coverage 99.74% 99.78% +0.04%
==========================================
Files 154 161 +7
Lines 2712 2765 +53
==========================================
+ Hits 2705 2759 +54
+ Misses 7 6 -1
Continue to review full report at Codecov.
|
|
Sorry this is my first PR ever. Anyone know what the issue is here? However, I don't know what codecov is and why the codecov/patch and codecov/project are failing. |
|
Codecov seems to be broken. It measures code coverage in our project. They changed how they calculate that recently and it hasn't recovered. You can safely ignore it for now. |
| .should.have.prop('active', true) | ||
| // `first().simulate('click')` closes the Dropdown so can't verify `prop('active', true)` | ||
| // TODO: Find a way to verify `first()` has `prop('active', true)` | ||
| // .should.have.prop('active', true) |
There was a problem hiding this comment.
I would think re-opening the dropdown would retain the active item. You could simply try something like (untested):
wrapper
.find('DropdownItem')
.first()
.simulate('click')
// re-open the dropdown
wrapper.setProps({ open: true })
wrapper
.find('DropdownItem')
.first()
.should.have.prop('active', true)
|
There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one. However, PRs for this issue will of course be accepted and welcome! If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks! |
levithomason
force-pushed
the
feat/dropdown/lazy-load
branch
from
d32dc07 to
1001f0e
Compare
levithomason
force-pushed
the
feat/dropdown/lazy-load
branch
from
79a6ddf to
57ada99
Compare
|
I've rebased this to master, moved the logic to a |
levithomason
changed the title
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Released in |
|
I just created a bug (#2975) , as I don't see this working as I would expect. |
Lazy-loading options will be very useful and efficient when there are many options.
We could eventually bind it to a prop like 'lazyLoad={true}'.