fix(Modal): fix state update after close #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Oct 25, 2017
|
|
||
| this.trySetState({ open: false }, { scrolling: false }) | ||
| _.invoke(this.props, 'onClose', e, this.props) | ||
| this.trySetState({ open: false }) |
There was a problem hiding this comment.
My initial suggestion there was falsy. It causes state after onClose was done.
The same effect can be archived when scrolling will be reseted in handleMount.
Codecov Report
@@ Coverage Diff @@
## master #2254 +/- ##
==========================================
- Coverage 99.73% 99.73% -0.01%
==========================================
Files 151 151
Lines 2624 2621 -3
==========================================
- Hits 2617 2614 -3
Misses 7 7
Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2236.