Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add missing period to script URL #2290

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

gitname
Copy link
Contributor

@gitname gitname commented Nov 5, 2017

Add a missing period (i.e. . character) to a URL. With the period absent, the docs website incorrectly references a JavaScript file hosted on a CDN. With the period present, the docs website correctly references that file.

This fixes issue #2289.

@codecov-io
Copy link

Codecov Report

Merging #2290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2290   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files         152      152           
  Lines        2656     2656           
=======================================
  Hits         2649     2649           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104916a...2dc40d0. Read the comment docs.

@gitname gitname changed the title Add missing period to URL fix(index): Add missing period to URL Nov 5, 2017
@gitname gitname changed the title fix(index): Add missing period to URL fix(index): add missing period to URL Nov 5, 2017
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitname Thanks

@layershifter layershifter merged commit f04a02f into Semantic-Org:master Nov 5, 2017
@layershifter layershifter changed the title fix(index): add missing period to URL fix(docs): add missing period to script URL Nov 5, 2017
@layershifter layershifter mentioned this pull request Nov 5, 2017
@levithomason
Copy link
Member

Released in semantic-ui-react@0.77.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants