feat(Image): improve handling of HTML props #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2316 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 152 152
Lines 2659 2659
=======================================
Hits 2652 2652
Misses 7 7
Continue to review full report at Codecov.
|
…Semantic-Org/Semantic-UI-React into feat/image-props # Conflicts: # src/elements/Image/Image.d.ts
src/elements/Image/Image.js
Outdated
| @@ -73,6 +71,7 @@ function Image(props) { | |||
| className, | |||
| ) | |||
| const rest = getUnhandledProps(Image, props) | |||
| const [imgTagProps, rootProps] = partitionHTMLInputProps(rest, { htmlProps: imageProps }) | |||
There was a problem hiding this comment.
This seems strange to overload an input prop parser for an image. Should this become a generic parser?
There was a problem hiding this comment.
Agree, I will update PR and we will go with partitionHTMLProps.
|
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2079.
This PR improves handling of HTML props using our
partitionHTMLInputPropsfunction and adds examples.