fix(Modal): scrolling disabled when modal unmounts #2394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2017
Also update tests to unmount modals after usage.
guillaumep
force-pushed
the
fix_scrolling
branch
from
057dff8 to
645b64f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2394 +/- ##
==========================================
+ Coverage 99.73% 99.73% +<.01%
==========================================
Files 152 152
Lines 2664 2667 +3
==========================================
+ Hits 2657 2660 +3
Misses 7 7
Continue to review full report at Codecov.
|
|
This looks good. Haven't tested, so I assume it works. Feels more react-y using a variable. I've still no clue how tests work and have been busy doing schoolwork so I'm good for either my approach or yours. |
|
So have this issue fixed yet? When I unmount a modal the original modal keep frozen on the scrolling. |
|
Closing in favor of #2407 as it promotes more proper solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1157, fixes #2248.
Another PR was opened for this fix, #2255. This PR is an alternative approach, possibly more generic.
At Modal mount time we check if the mount node has the scrolling class, and keep that information in a class variable (scrollingWasDefinedAtMountTime). At Modal umount, we reset the scrolling class to its original value.
I will see to add tests to the PR as well, today or next week.