fix(Progress): use correct width for value/total #2503
Conversation
…lue' and total is defined
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #2503 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 154 154
Lines 2711 2712 +1
==========================================
+ Hits 2704 2705 +1
Misses 7 7
Continue to review full report at Codecov.
|
| <Divider hidden /> | ||
| <Item.Description> | ||
| <Progress progress='value' value={5} total={7} content='Fashion' color='purple' /> | ||
| <Progress progress='value' value={2} total={7} content='Cats' color='yellow' /> |
There was a problem hiding this comment.
Let's simplify this example down to the minimum amount code required to show the feature. It makes the docs a little quicker to scan and the doc code editor easier to play with.
There was a problem hiding this comment.
Sure, good idea. I wasn't sure if an example use case might be useful. Would there be somewhere else more appropriate to add the example I did?
I'll update this with a simpler example tomorrow.
There was a problem hiding this comment.
Right now we don't have a formal place for more cohesive examples. It may be something we add in the future.
|
Just one comment there. Looks great otherwise! |
levithomason
changed the title
value and both value and total are set, display progress bar at the percentage of value/total
|
Updated with a simpler example. |
|
@levithomason ready to review 👍 |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Released in |
* fix(Progress): adds condition to display percentage when progress='value' and total is defined * docs(Progress): add example of progress bar with progress='value' and total defined * lint error fix * adding simpler example
This is a fix for #2502