Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(TableExamplePagination): order icon names per docs #2534

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

searene
Copy link
Contributor

@searene searene commented Feb 18, 2018

According to https://react.semantic-ui.com/elements/icon, chevron left and chevron right should be used.

According to https://react.semantic-ui.com/elements/icon, `chevron left` and `chevron right` should be used.
@welcome
Copy link

welcome bot commented Feb 18, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@levithomason
Copy link
Member

Icon names are not order dependent. However, the typescript is not as forgiving as the prop type checker and the CSS.

Since we've had this PR twice in the last week or two, I'll go ahead and merge this one 👍

@levithomason levithomason changed the title docs(TableExamplePagination): your description docs(TableExamplePagination): order icon names per docs Feb 18, 2018
@codecov-io
Copy link

Codecov Report

Merging #2534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2534   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         154      154           
  Lines        2712     2712           
=======================================
  Hits         2705     2705           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7d96f...215d56b. Read the comment docs.

@levithomason levithomason merged commit 3f26bef into Semantic-Org:master Feb 18, 2018
@welcome
Copy link

welcome bot commented Feb 18, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@searene searene deleted the patch-1 branch February 18, 2018 09:28
@levithomason
Copy link
Member

Released in semantic-ui-react@0.78.3.

Brantron pushed a commit to Brantron/Semantic-UI-React that referenced this pull request Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants