feat(Dropdown): add direction prop #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
feat/dropdown-direction
branch
from
8c984e0 to
1ce6f0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2536 +/- ##
==========================================
- Coverage 99.74% 99.74% -0.01%
==========================================
Files 160 160
Lines 2745 2744 -1
==========================================
- Hits 2738 2737 -1
Misses 7 7
Continue to review full report at Codecov.
|
|
Released in |
Brantron
pushed a commit
to Brantron/Semantic-UI-React
that referenced
this pull request
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1897
This PR adds the
directionprop to the Dropdown. This enables opening the menu aligned the left or right of the dropdown element. Great for right aligned dropdowns with long items.It also moves the responsibility of className build up to the DropdownMenu. The DropdownMenu now has props for
openanddirection.