Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): omit aria-hidden attribute when aria-label prop is truthy #2666

Merged

Conversation

benbakhar
Copy link
Contributor

Fixes #2652

Details

Prevent setting aria-hidden attribute when aria-label property is passed. For all other cases aria-hidden="true" is set.

@welcome
Copy link

welcome bot commented Mar 20, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #2666 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2666      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%     
==========================================
  Files         160      160              
  Lines        2751     2757       +6     
==========================================
+ Hits         2744     2750       +6     
  Misses          7        7
Impacted Files Coverage Δ
src/elements/Icon/Icon.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8514a30...bd8adf1. Read the comment docs.

@levithomason levithomason merged commit d895cec into Semantic-Org:master Mar 27, 2018
@welcome
Copy link

welcome bot commented Mar 27, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@benbakhar benbakhar deleted the fix/icon-aria-hidden-attr branch March 27, 2018 11:49
@levithomason
Copy link
Member

Released in semantic-ui-react@0.79.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants