Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ads): fix adblock detect, add opt out #2679

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Mar 24, 2018

There is an annoying bug with the current ad. It sometimes thinks you're blocking ads when you aren't. I've switched to f*adblock for detection. I've also added a "No thanks" button to the support section so users can opt out of ads entirely for two weeks at a time.

@codecov-io
Copy link

Codecov Report

Merging #2679 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2679   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         160      160           
  Lines        2751     2751           
=======================================
  Hits         2744     2744           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2363cd...b5325e6. Read the comment docs.

@levithomason levithomason merged commit 6d634ac into master Mar 25, 2018
@levithomason levithomason deleted the docs/ad-block-detect branch March 25, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants