chore(package): use Babel 7 #2750
Conversation
| ReactDOM.render(<App />, mountNode) | ||
| </script> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
This file allowed manual testing to ensure the UMD build worked. It was originally created to verify that the codepen would work as codepen used the UMD bundle. Since we now use codesandbox and it doesn't need a UMD, it is probably safe to remove.
In fact, I wonder if we anyone actually uses the UMD bundle at all. It would simplify and speed things up if we removed it.
There was a problem hiding this comment.
I'm think that we will drop UMD build in near future 👍
| @@ -113,10 +113,9 @@ | |||
| "express": "^4.15.4", | |||
| "faker": "^4.1.0", | |||
| "gh-pages": "^1.0.0", | |||
| "gulp": "gulpjs/gulp#4.0", | |||
| "gulp-html-replace": "^1.6.2", | |||
Codecov Report
@@ Coverage Diff @@
## master #2750 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 160 160
Lines 2758 2758
=======================================
Hits 2751 2751
Misses 7 7Continue to review full report at Codecov.
|
| @@ -15,7 +15,7 @@ import ComponentControls from '../ComponentControls' | |||
| import ComponentExampleTitle from './ComponentExampleTitle' | |||
|
|
|||
| const babelConfig = { | |||
| presets: ['es2015', 'react', 'stage-1'], | |||
| presets: ['es2015', 'react', ['stage-1', { decoratorsLegacy: true }]], | |||
There was a problem hiding this comment.
Can we use babel-preset-env in the browser too?
| </Grid.Column> | ||
| )} | ||
| </Grid.Row> | ||
| <Grid.Row columns={1}>{children && <Grid.Column style={childrenStyle}>{children}</Grid.Column>}</Grid.Row> |
There was a problem hiding this comment.
Perhaps we should shorten our line length. This is quite hard to read.
<Grid.Row columns={1}>{children && <Grid.Column style={childrenStyle}>{children}</Grid.Column>}</Grid.Row>This line is 118 columns, maybe go with 100 columns?
<Grid.Row columns={1}>
{children && <Grid.Column style={childrenStyle}>{children}</Grid.Column>}
</Grid.Row>
…React into chore/babel7 # Conflicts: # package.json # yarn.lock
| @@ -31,6 +31,7 @@ | |||
| "prettier": "prettier --list-different \"**/*.{js,jsx,ts,tsx}\"", | |||
| "prettier:fix": "prettier --write \"**/*.{js,jsx,ts,tsx}\"", | |||
| "precommit": "lint-staged", | |||
| "postcommit": "git update-index --again", | |||
There was a problem hiding this comment.
|
Released in |
Fixes #2603.
This PR: