feat(Visibility): add updateOn prop
#2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
feat/visibility-update-on
branch
2 times, most recently
from
c3a9a12 to
cc3f0e6
Compare
layershifter
force-pushed
the
feat/visibility-update-on
branch
from
cc3f0e6 to
d59010e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2791 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 160 160
Lines 2773 2777 +4
==========================================
+ Hits 2766 2770 +4
Misses 7 7
Continue to review full report at Codecov.
|
| @@ -537,4 +537,36 @@ describe('Visibility', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('updateOn', () => { | |||
There was a problem hiding this comment.
We should add a test here that it() defaults to events. Also, it would be great to have an event based assertion to ensure that events are still working.
There was a problem hiding this comment.
I added a new test to test the default value. All other tests work with events, so I don't think that we need to duplicate any of them.
|
❤️ |
…React into feat/visibility-update-on
layershifter
force-pushed
the
feat/visibility-update-on
branch
from
7fc8616 to
a364d0c
Compare
layershifter
force-pushed
the
feat/visibility-update-on
branch
from
a364d0c to
2e069c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2318.