fix(Sticky): prevent npe error after unmount of component #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracmak
commented
May 30, 2018
| @@ -217,7 +220,7 @@ export default class Sticky extends Component { | |||
| didReachContextBottom = () => { | |||
| const { offset } = this.props | |||
|
|
|||
| return (this.stickyRect.height + offset) >= this.contextRect.bottom | |||
There was a problem hiding this comment.
I believe these lines changed because of prettier/eslint --fix
Codecov Report
@@ Coverage Diff @@
## master #2854 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 160 160
Lines 2777 2779 +2
==========================================
+ Hits 2770 2772 +2
Misses 7 7
Continue to review full report at Codecov.
|
fracmak
force-pushed
the
sticky-umount-bug
branch
from
692ad5f to
def4afe
Compare
layershifter
force-pushed
the
sticky-umount-bug
branch
from
bbd209b to
6915f52
Compare
layershifter
approved these changes
May 31, 2018
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a simple problem where the event listeners call handleUpdate() which calls requestAnimationFrame to call the update function in the next tick, but if the component unmounts between the handleUpdate call and the requestAnimationFrame firing, we get an NPE error because the handleTriggerRef function has been fired with null as the ref ( reference: https://reactjs.org/docs/refs-and-the-dom.html#adding-a-ref-to-a-dom-element ).
This prevents that from happening by saving the requestId from requestAnimationFrame and clearing it on componentWillUnmount