Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ComponentExample): remove filter effect #2866

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Jun 3, 2018

Fixes #2865

The grayscale filter effect was intended to bring focus to an example when editing code. However, it is also made active when clicking an example link in the right menu. This is confusing and distracting, ironic as it is.

@levithomason levithomason mentioned this pull request Jun 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #2866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2866   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files         161      161           
  Lines        2733     2733           
=======================================
  Hits         2724     2724           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011c495...5c5c8ef. Read the comment docs.

@levithomason levithomason merged commit b2361f7 into master Jun 3, 2018
@levithomason levithomason deleted the docs/improve-active-example branch June 3, 2018 03:03
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.81.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants